Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuickJS #331

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update QuickJS #331

merged 1 commit into from
Jul 19, 2024

Conversation

richarddd
Copy link
Contributor

Adds latest changes from upstream

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (304db5d) to head (b3c337e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #331       +/-   ##
===========================================
- Coverage   68.31%   55.81%   -12.51%     
===========================================
  Files          83       83               
  Lines       12237    12237               
===========================================
- Hits         8360     6830     -1530     
- Misses       3877     5407     +1530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richarddd
Copy link
Contributor Author

Hi @DelSkayn, i think CI is broken since it targets rust 1.65. Please take a look when you have the time

@DelSkayn
Copy link
Owner

The CI breaking was apparently due to a raise in the MSRV of cc which has since been reverted. I will probably have to raise the MSRV of rquickjs soon when cc bumps it MSRV again.

@DelSkayn DelSkayn merged commit 4eaf5f9 into DelSkayn:master Jul 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants