Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling "logger.complete()" hangs forever when sink failed if "enqueue=True" and "catch=False" #647

Closed
Delgan opened this issue May 3, 2022 · 0 comments
Closed

Calling "logger.complete()" hangs forever when sink failed if "enqueue=True" and "catch=False" #647

Delgan opened this issue May 3, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Delgan
Copy link
Owner

Delgan commented May 3, 2022 

from loguru import logger

def fail(_):
    raise ValueError("Fail")

logger.add(fail, enqueue=True, catch=False)
logger.info("Failure")
logger.complete()

It hangs while it shouldn't.
Delgan added a commit that referenced this issue May 3, 2022
@Delgan
Fix "complete()" possibly hanging forever if "enqueue=True" (#647)
4c9b7e0
@Delgan Delgan closed this as completed May 3, 2022
@Delgan Delgan added the bug Something isn't working label May 3, 2022
Delgan added a commit that referenced this issue Mar 26, 2023
@Delgan
Fix possible hang when "complete()" called twice and crashed thread
3d26e5d 
See #647. The initial fix didn't prevented "complete()" to hang
if it was called a second time.
Delgan added a commit that referenced this issue Mar 26, 2023
@Delgan
Fix possible hang when "complete()" called twice and crashed thread
b9acbad 
See #647. The initial fix didn't prevented "complete()" to hang
if it was called a second time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Delgan