Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 release fix for windows binary match in update & scoop configs #108

Merged
merged 1 commit into from
May 13, 2023

Conversation

sheldonhull
Copy link
Contributor

@sheldonhull sheldonhull commented May 12, 2023

🤖 Generated by Copilot at e4e22cc

Summary

🐛🛠️🚀

This pull request improves the changelog management and the cli release process. It adds more fields and labels to the .changie.yaml file, fixes the CHANGELOG.md formatting, fixes the Windows download URLs and version check issue, and automates the version bumping and release messages.

The cli team has made some nice changes
To fix bugs and bump up the ranges
They updated goreleaser
And .changie and .changes
And polished the CHANGELOG.md pages

Walkthrough

  • Add changelog entry for version 1.40.5 with bug fix for Windows cli version update check issue (link, link)
  • Update changie configuration to enable block input for change body, add new labels and auto bump types for change kinds, and add newline before each kind section in changelog (link, link)
  • Fix download URLs for Windows binaries in goreleaser.mage.custom.go to match artifact names (link)
  • Change Bump function in goreleaser.mage.custom.go to use automatic bump based on changie kinds instead of interactive select prompt (link)
  • Change Bump function in goreleaser.mage.custom.go to use interactive text input for commit message instead of default message (link)

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #108 (e4e22cc) into main (a2521eb) will increase coverage by 18.78%.
The diff coverage is 45.89%.

@@             Coverage Diff             @@
##             main     #108       +/-   ##
===========================================
+ Coverage   32.61%   51.39%   +18.78%     
===========================================
  Files          80       86        +6     
  Lines       10855    11880     +1025     
===========================================
+ Hits         3540     6106     +2566     
+ Misses       7027     5475     -1552     
- Partials      288      299       +11     
Impacted Files Coverage Δ
auth/encryption.go 54.54% <ø> (+33.33%) ⬆️
auth/method_password.go 72.72% <ø> (+36.36%) ⬆️
commands/siem.go 23.05% <0.00%> (+23.05%) ⬆️
constants/commands.go 75.00% <ø> (+25.00%) ⬆️
internal/store/pass_store.go 0.00% <ø> (ø)
internal/store/secure_store.go 0.00% <0.00%> (ø)
internal/store/win_store_notwindows.go 0.00% <ø> (ø)
utils/test_helpers/encryption.go 0.00% <ø> (ø)
vaultcli/cli_options.go 62.50% <ø> (+62.50%) ⬆️
vaultcli/config.go 54.10% <ø> (+19.32%) ⬆️
... and 26 more

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sheldonhull sheldonhull enabled auto-merge (squash) May 12, 2023 21:54
@sheldonhull sheldonhull merged commit c18d312 into main May 13, 2023
21 checks passed
@sheldonhull sheldonhull deleted the fix/artifact-for-windows-name branch May 13, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants