Allow different weight matrices to be passed in for path weight calculations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 67.10% 66.54% -0.56%
==========================================
Files 11 11
Lines 836 843 +7
==========================================
Hits 561 561
- Misses 275 282 +7
Continue to review full report at Codecov.
|
mmiller-max
force-pushed
the
mm/new-methods-for-weights
branch
from
1ea0df8
to
48ada27
Compare
captchanjack
approved these changes
Aug 26, 2021
| @@ -119,12 +119,13 @@ Extracts edge weights from a path using `g.weights`. | |||
| # Arguments | |||
| - `g::OSMGraph`: Graph container. | |||
| - `path::Vector{T}`: Array of OpenStreetMap node ids. | |||
| - `weights=g.weights`: weights matrix. | |||
|
|
|||
There was a problem hiding this comment.
put comment on kwarg in doc string
src/shortest_path.jl
Outdated
| @@ -135,14 +136,15 @@ Extract total edge weight along a path. | |||
| # Arguments | |||
| - `g::OSMGraph`: Graph container. | |||
| - `path::Vector{T}`: Array of OpenStreetMap node ids. | |||
| - `weights=g.weights`: weights matrix. | |||
mmiller-max
force-pushed
the
mm/new-methods-for-weights
branch
from
48ada27
to
5804e5f
Compare
mmiller-max
force-pushed
the
mm/new-methods-for-weights
branch
from
5804e5f
to
bdf0159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the update to
shortest_path, allow users to pass their own weight matrices intototal_path_weightandweights_from_path