Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test for common_layer #79

Merged
merged 3 commits into from
Sep 4, 2019
Merged

add unit test for common_layer #79

merged 3 commits into from
Sep 4, 2019

Conversation

GaryGao99
Copy link
Collaborator

Thank you for submitting a pull request! Please provide the following information for code review:

Pull Request Summary

[TODO] add unit test for common_layer. Fix #31

Test Plan

[TODO] python comon_layer_test.py

zh794390558
zh794390558 approved these changes Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zh794390558 zh794390558 merged commit 08de503 into master Sep 4, 2019
@zh794390558 zh794390558 deleted the common_layer_unit_test branch September 4, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zh794390558 zh794390558 zh794390558 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor common_layers.py and add unit test
2 participants
@GaryGao99 @zh794390558