This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Maven repair, create readme #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnuh
reviewed
Jul 24, 2019
| @@ -184,7 +184,7 @@ public void setRoom(Location l, String submissionId) { | |||
| spawnHologram(bl.clone().add(.5, .5, .5), title); | |||
| } | |||
|
|
|||
| spawnHologram(bl.clone().add(.5, -.25, .5), "�6"+s.getScore()); | |||
| spawnHologram(bl.clone().add(.5, -.25, .5), "" + (char)(0xfeff00a7) + "6" + s.getScore()); | |||
There was a problem hiding this comment.
Any reason why this isn't using ChatColor api?
There was a problem hiding this comment.
Would you like to implement it? I created this issue #2 for you.
|
Hey there, super active developer in the MC community, once this PR is accepted, I'd be happy to go through and clean it up a tad more for you. Yes maven might be annoying if you're not used to it, but I'd be happy to take a few moments and clean it up! |
|
Wow! Thank you so much. |
|
Im kind of worried that no one changed the names of my „I hate maven“ and „IAHTRE“ repos hahaha |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to tidy up the repo by removing compiled files, adding a build script, and beginning documentation,