eta_init and eta0 in checkpointing #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 1, 2024 09:47
…he initial on all simulation time, and the latter being the previous timestep eta.
…ing else is present.
… pull requests from fork. v4 should autoswitch to tokenless uploading to codecov, but may still be rate limited. might need to switch away from codecov.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
+ Coverage 78.86% 78.88% +0.02%
===========================================
Files 12 12
Lines 2616 2619 +3
===========================================
+ Hits 2063 2066 +3
Misses 553 553 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
eta_initandeta0to the output of checkpoints.Also adds these to checkpoint loading and adds a simple test to check that all fields are present. This is just to try and promote consistency.