specify integer type to be compatible with 32-bit systems. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoodie
force-pushed
the
fix-seed_windows
branch
from
896eaf6
to
5f3ee2a
Compare
amoodie
force-pushed
the
fix-seed_windows
branch
from
5f3ee2a
to
9d092dd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #65 +/- ##
========================================
Coverage 83.07% 83.07%
========================================
Files 11 11
Lines 1176 1176
========================================
Hits 977 977
Misses 199 199
Continue to review full report at Codecov.
|
amoodie
force-pushed
the
fix-seed_windows
branch
from
c2f86a1
to
a3c59bf
Compare
|
I'm just merging this because it's a simple bug fix. Hope y'all are cool with that. |
amoodie
added a commit
to amoodie/pyDeltaRCM
that referenced
this pull request
Feb 25, 2021
specify integer type to be compatible with 32-bit systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
I think that the random seed issue was a 32-bit issue, rather than a Windows issue. However, after fixing that, windows build still failed, due to some path issues in the tests. Fixed those too.