DIMR, RainfallRunoffModel & FMModel are not read

[d2hydro]

Describe the bug
This model runs perfectly fine in DHYDRO, but won't be read by HYDROLIB-core v0.2.1: https://we.tl/t-GWED4R2YLX

To Reproduce
Steps to reproduce the behavior:

1. download and unzip, run it with DHYDRO dimr -> it runs
2. import the hydrolib.core models DIMR, FMModel and RainfallRunoffModel in python
3. Try:

• DIMR(filepath=Path("path_to/dimr_config.xml")) --> ❗ TODO
• RainfallRunoffModel(filepath=Path("path_to/Sobek_3b.fnm")) --> Fixed by cf20bc3
• FMModel(filepath=Path("path_to/dellen.mdu"))
  • --> ✅ the "partitionFile error" must be fixed in input: there may be only one single line with partitionFile, now there's two.
  • --> ✅ the forcing error was fixed by 63fa0c6

5. See all giving validation errors

Expected behavior
All models are accepted as they are by DHYDRO

Screenshots

Version info (please complete the following information):

• OS: windows
• Version: 0.2.1

Additional context
Please help

[d2hydro]

@arthurvd regarding the error DIMR(filepath=Path("path_to/dimr_config.xml")); could it be that an RTC-component is not implemented yet? I guess as it would be expected below this line in the dimr-model:

HYDROLIB-core/hydrolib/core/io/dimr/models.py

Line 80 in a2ddd6d

class FMComponent(Component):

.

If so, is there a work-around?

[d2hydro]

regarding the error in RainfallRunoffModel; tracked it to this line:

HYDROLIB-core/hydrolib/core/io/rr/topology/parser.py

Line 47 in a2ddd6d

substring = get_substring_between(line, key_start, key_end)

:

substring = get_substring_between(line, key_start, key_end)

key_start = BRCH, key_end = brch.

The file send contains brch in the nm property, which effectively results in a substring containing only id.

Suggest the following fix:
replace: index_end = source.find(end, index_start)
in line:

HYDROLIB-core/hydrolib/core/utils.py

Line 100 in a2ddd6d

index_end = source.find(end, index_start)

by: index_end = source.rfind(end, index_start)

then the function get_substring_between will find the substring between the most left key_start and the most right key_end

[d2hydro]

regarding the issue at FMModel: HYDROLIB does not seem to be able to handle bc-files with only 1x [Forcing] as in the example:

Solved it by adding _split_to_list = make_list_validator("forcing") in ForcingModel:

HYDROLIB-core/hydrolib/core/io/bc/models.py

Line 211 in 63fa0c6

_split_to_list = make_list_validator("forcing")