Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors when parsing .mdu file - types of certain keywords need to be changed #240

Closed
JulienGroenenboom opened this issue Jun 1, 2022 · 1 comment · Fixed by #283
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@JulienGroenenboom
Copy link

Describe the bug
I get validation errors (type_error's) when loading some of my *.mdu files.

I think some changes are needed in: hydrolib.core.io.mdu.models.py

[physics]
umodLin ; type should be float instead of int to avoid the validation error # Note that based on the D-Flow FM manual, you might expect an integer. However, in D-Flow FM this is read as a float. Change needed in HYDROLIB-core or in D-Flow FM?
betaSpiral ; type should be float instead of int

[trachytopes]
TrtL ; type should be [str] instead of [int]
TrtDef ; type should be [str] instead of [int]

[wind]
relativewind ; type should be float instead of bool # this recently changed in D-Flow FM from boolean to float

@arthurvd arthurvd added the type: bug Something isn't working label Jul 8, 2022
@arthurvd arthurvd added this to To do in HYDROLIB-core via automation Jul 8, 2022
@priscavdsluis priscavdsluis moved this from To do to In progress in HYDROLIB-core Jul 12, 2022
@priscavdsluis priscavdsluis linked a pull request Jul 13, 2022 that will close this issue
@priscavdsluis priscavdsluis moved this from In progress to Ready to review in HYDROLIB-core Jul 13, 2022
@priscavdsluis priscavdsluis self-assigned this Jul 13, 2022
@priscavdsluis
Copy link
Contributor

Hi @arthurvd, as discussed, could you update the manual for the 5 keywords?

@arthurvd arthurvd moved this from Ready to review to Review in progress in HYDROLIB-core Jul 13, 2022
HYDROLIB-core automation moved this from Review in progress to Done Jul 13, 2022
@priscavdsluis priscavdsluis added this to the Release 0.4 milestone Jul 14, 2022
@priscavdsluis priscavdsluis modified the milestones: Release 0.4, 0.3.1 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
HYDROLIB-core
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants