-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading invalid formatted plifile should raise error instead of warning #320
Comments
Case with valid formatted pli file & UserWarning: White space at the start of the line is ignored, already resolved in #370 |
Discussed with Jelmer: In all cases in which the file is invalid, an exception error should be raised, instead of a warning |
…date test cases for changes.
For completeness: @veenstrajelmer and @MRVermeulenDeltares : this morning we were discussing that for now we will NOT support reading of support point labels at the end of a data line (but don't raise an error if they are present). Coincidentally, @xldeltares has reported that she is hampered by that, see new issue #467. I will continue discussion over there and keep this issue closed (because this issue here was only about changing warning into error, regardless of what we do and do not support in pli files) |
Describe the bug
Reading invalid formatted plifile should raise error instead of warning.
To Reproduce
Expected behavior
Case with comments added (not supported by hydrolib, but no issue for dflowfm kernel). I would say a # is necessary but also that is not supported.
Case with invalid nrows in plifile
Case with valid formatted pli file
Version info (please complete the following information):
The text was updated successfully, but these errors were encountered: