Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branchOrder not written to nc file #334

Closed
xldeltares opened this issue Sep 2, 2022 · 1 comment
Closed

branchOrder not written to nc file #334

xldeltares opened this issue Sep 2, 2022 · 1 comment

Comments

@xldeltares
Copy link
Collaborator

Describe the bug
branchOrder not written to nc file.

To Reproduce
Steps to reproduce the behavior:
in net\models.py on line 775: self.network1d_branch_order = np.append(self.network1d_branch_order, -1)
The branchOder is always appended with -1.

Expected behavior
branch_order is passed to the function as an input argument. It should be used here
in net\models.py on line 775: self.network1d_branch_order = np.append(self.network1d_branch_order, branch_order)
xldeltares added a commit that referenced this issue Sep 2, 2022
@xldeltares
#334 fix branchorder writing to net file
d0cead9
priscavdsluis pushed a commit that referenced this issue Sep 2, 2022
@xldeltares
fix: write correct branchorder to net file (#335)
40d7df2 
* #334 fix branchorder writing to net file

* autoformat: isort & black

Co-authored-by: xldeltares <xldeltares@users.noreply.github.com>
@rhutten rhutten closed this as completed Sep 6, 2022
@rhutten
Copy link
Collaborator

rhutten commented Sep 6, 2022

Issues is already merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhutten @xldeltares