272#: Refactor get_location_specification_root_validator #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cationValidationFieldNames attributes.
…tion-root-validator
tim-vd-aardweg
requested changes
Oct 4, 2022
… when `validate_num_coordinates` = False
…tion-root-validator
arthurvd
requested changes
Oct 5, 2022
There was a problem hiding this comment.
Hi @priscavdsluis, can you also check my few small comments?
|
Kudos, SonarCloud Quality Gate passed!
|
arthurvd
approved these changes
Oct 7, 2022
tim-vd-aardweg
deleted the
refactor/272-refactor-get-location-specification-root-validator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the existing
get_location_specification_rootvalidatorand removed theget_number_of_coordinates_validator. This one is merged in the new validator.The validator is now configurable with a configuration class and the field names are also adjustable with a separate class.
The validator is made up of local functions.
Normally, local functions are not really nice I think, but because we need to have all the information, I think it is better to keep them private and local. This makes the "body" of the actual validation method more tidy and clean.
The validation method now has a more step-wise implementation.