#438: Only update the file path if resolve_casing is set to True.
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscavdsluis
changed the title
resolve_casing is set to True.
priscavdsluis
changed the title
resolve_casing is set to True.
…s-for-diskonlyfilemodel
MRVermeulenDeltares
moved this from Ready to review
to Review in progress
in HYDROLIB-core
…s-for-diskonlyfilemodel
|
Kudos, SonarCloud Quality Gate passed!
|
MRVermeulenDeltares
approved these changes
Apr 7, 2023
MRVermeulenDeltares
approved these changes
Apr 7, 2023
priscavdsluis
deleted the
fix/435-incorrect-resolving-of-relative-paths-for-diskonlyfilemodel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #435
This PR does not fix the root problem.
Using ".." in relative file paths in combination with the resolve file path casing functionality leads to incorrect file paths.
This PR only added a condition. This means the bug is solved for users that do not use the resolve file path casing functionality.
But we still need to think about how to fix the root problem it in a different PR.