Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pydantic 2, but use V1 API. #589

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Use Pydantic 2, but use V1 API. #589

merged 3 commits into from
Jan 12, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Nov 20, 2023 •
edited
Loading

@evetion
Copy link
Member Author

evetion commented Jan 8, 2024

@arthurvd @priscavdsluis Can we review/merge/release this? It would be good if we can use ribasim & hydrolib(-core) together again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@priscavdsluis priscavdsluis merged commit 892b531 into main Jan 12, 2024
6 checks passed
@priscavdsluis priscavdsluis deleted the feat/pydantic-v2-v1 branch January 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priscavdsluis priscavdsluis priscavdsluis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update hydrolib-core to Pydantic V2 Migrate to Pydantic V2
2 participants
@evetion @priscavdsluis