Feature/gridedit 899 undo in meshkernel #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases rather than base class
…moved during the administration
Changed name of function from GetNumActiveNodes/Edges to GetNumValidNodes/Edges Fixed windows compilation error.
Added extra members to Mesh1/2D, for the number of valid nodes and edges
…re set to invalid
Updated error message when index is out of range.
…fo in failure in TC
… some noade and their indices, depending on which requires the least memory.
Updated mesh transformation tests to include undo test
Minor refactoring of the move node, it now uses the NodeTranslationAction
…etry to include Apple as well as Linux
lucacarniato
approved these changes
Mar 12, 2024
| m_restored.clear(); | ||
| } | ||
|
|
||
| std::uint64_t meshkernel::UndoActionStack::MemorySize() const |
There was a problem hiding this comment.
I see the utility of this as long we want to measure memory consumption. it would be nice to remove this method when we do not need to measure anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.