Feature/gridedit 992 add api for inserting edges #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
approved these changes
Mar 27, 2024
Comment on lines
1635
to
1637
| { | ||
| auto result = meshKernelState[meshKernelId].m_mesh2d->InsertNode(firstNodeCoordinates); | ||
| firstNodeId = std::get<0>(result); |
There was a problem hiding this comment.
You may get a sonarcloud warning here to use structured binding.
Could use std::tie
Comment on lines
1645
to
1647
| { | ||
| auto result = meshKernelState[meshKernelId].m_mesh2d->InsertNode(secondNodeCoordinates); | ||
| secondNodeId = std::get<0>(result); |
BillSenior
reviewed
Mar 27, 2024
Comment on lines
1625
to
1627
| const auto newEdgeLength = ComputeDistance(firstNodeCoordinates, secondNodeCoordinates, meshKernelState[meshKernelId].m_projection); | ||
| const auto edgeLengths = meshKernelState[meshKernelId].m_mesh2d->m_edgeLengths; | ||
| const auto lengthFraction = 0.01; |
There was a problem hiding this comment.
Perhaps make edgeLengths a reference
Unless mesh->m_edgeLengths is modified later and you do not want t get these updates.
lucacarniato
deleted the
feature/GRIDEDIT-992_add_api_for_inserting_edges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.