39 the return code of the sfincs model is always 0 even if the model fails #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The -1 is now accessible out of ierr = sfincs_update loop when running through BMI I think - However, not yet as windows exe error message, since still the program stops normally, requires more work - Note, branch is split from current main, which had some small issues in quadtree netcdf when compiling in debug mode
- fix some typos
…, especially in case of errors!
|
Thanks a lot for checking and improving on this Maarten! |
Leynse
deleted the
39-the-return-code-of-the-sfincs-model-is-always-0-even-if-the-model-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.