KISS-111, add api for writing double variables with mesh locations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwplatzek
reviewed
Mar 17, 2022
| Edges = 2, ///< Edges | ||
| }; | ||
|
|
||
| static std::unordered_map<MeshLocations, std::string> locations_attribute_names{ |
There was a problem hiding this comment.
Do you need Doxygen documentation here?
fwplatzek
reviewed
Mar 17, 2022
src/UGridApi/UGrid.cpp
Outdated
| throw std::invalid_argument("UGrid: The selected file_id does not exist."); | ||
| } | ||
|
|
||
| const auto name = ugrid::char_array_to_string(variable_name, ugrid::name_long_length); |
There was a problem hiding this comment.
This variable name does not seem to be used. Can it be removed, or should line 326 use name instead of variable_name, or somehing else?
fwplatzek
reviewed
Mar 17, 2022
src/UGridApi/UGrid.cpp
Outdated
| } | ||
| if (mesh_location_enum == MeshLocations::Nodes) | ||
| { | ||
| coordinates = get_coordinate_variable_string(file_id, topology_id, Mesh2dTopology, "node_coordinates"); |
There was a problem hiding this comment.
Do we need a:
location = "nodes";
here?
…riable on location
Output binaries into bin
fwplatzek
reviewed
Mar 21, 2022
| @@ -163,6 +163,20 @@ namespace ugridapi | |||
| return it->second; | |||
| } | |||
|
|
|||
| static auto get_coordinate_variable_string(int file_id, int topology_id, int topology_type, std::string const& var_name) | |||
There was a problem hiding this comment.
std::string const& var_name ?
or
const std::string& var_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.