Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed timestep river kinematic wave #191

Closed
verseve opened this issue Jan 5, 2022 · 0 comments · Fixed by #192
Closed

fixed timestep river kinematic wave #191

verseve opened this issue Jan 5, 2022 · 0 comments · Fixed by #192
Assignees
@verseve
Labels
bug Something isn't working

Comments

@verseve
Copy link
Member

verseve commented Jan 5, 2022

If the model timestep is smaller than the fixed timestep for kinematic wave river (kw_river_tstep) an InExactError is thrown. The number of iterations for river flow:

Wflow.jl/src/flow.jl

Line 166 in 0190b5b

its = tstep > 0 ? ceil(Int(tosecond(Δt) / tstep)) : tstep,

should be calculated in the same way as for overland flow:

Wflow.jl/src/flow.jl

Line 82 in 0190b5b

its = tstep > 0 ? Int(cld(tosecond(Δt), tstep)) : tstep,

@verseve verseve added the bug Something isn't working label Jan 5, 2022
@verseve verseve self-assigned this Jan 5, 2022
@verseve verseve mentioned this issue Jan 10, 2022
Merged
@verseve verseve linked a pull request Jan 10, 2022 that will close this issue
Fix issues #181 and #191 #192
Merged
verseve added a commit that referenced this issue Jan 13, 2022
@verseve
Merge pull request #192 from Deltares/fix-issues
b1f113e 
Fix issues #181 and #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verseve verseve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues #181 and #191 Deltares/Wflow.jl
1 participant
@verseve