Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving total evaporation with SBM #263

Closed
hboisgon opened this issue May 23, 2023 · 1 comment · Fixed by #264
Closed

Saving total evaporation with SBM #263

hboisgon opened this issue May 23, 2023 · 1 comment · Fixed by #264
Assignees

Comments

@hboisgon
Copy link
Contributor

Hi ,
I was trying to do some kind of catchment mass balance with for example total precipitation, evaporation, infiltration, recharge etc.

For total evaporation in the basin, I thought actevap (Total actual evapotranspiration) was the variable for this but in the code, there is:
actevap = soilevap + transpiration + ae_openw_r + ae_openw_l
So I think the interception component is missing, or if we keep actevap as is, maybe we should create a new variable that also includes it?

Also related, in the docs it says that soilevap is soil evaporation from unsaturated store, but in the code this is actually sat + unsat (soilevapunsat is not saved in sbm struct):

soilevap = soilevapunsat + soilevapsat

@verseve
Copy link
Member

verseve commented May 23, 2023

Yes, good point, others have also noticed this and it is a bit confusing. I will change actevap to include interception. And thanks for spotting that soilevap in the docs is not correct, will fix this.

@verseve verseve self-assigned this May 23, 2023
@verseve verseve linked a pull request May 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants