Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interception to total actual evapotranspiration actevap #264

Merged
merged 3 commits into from
May 23, 2023
Merged

Add interception to total actual evapotranspiration actevap #264

merged 3 commits into from
May 23, 2023

Conversation

verseve
Copy link
Member

@verseve verseve commented May 23, 2023

No description provided.

@verseve verseve linked an issue May 23, 2023 that may be closed by this pull request
Saving total evaporation with SBM #263
Closed
@verseve verseve requested a review from hboisgon May 23, 2023 06:50
hboisgon
hboisgon approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for updating it so fast!
One small comment is that for soilevap the definition in the struct also says its evap from unsat but this is less crucial to update for most users. So I approve for now so that you can easily merge

@verseve verseve merged commit 7790afd into master May 23, 2023
@verseve verseve deleted the actevap branch May 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboisgon hboisgon hboisgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving total evaporation with SBM
2 participants
@verseve @hboisgon