Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't break if h_bankfull is still used #199

Merged
merged 3 commits into from
Feb 3, 2022
Merged

don't break if h_bankfull is still used #199

merged 3 commits into from
Feb 3, 2022

Conversation

visr
Copy link
Member

@visr visr commented Feb 2, 2022

By accepting it as an alias, and giving a warning about the name change.

@visr visr requested a review from verseve February 2, 2022 16:19
verseve
verseve requested changes Feb 2, 2022
View reviewed changes
Copy link
Member

@verseve verseve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have two comments.

docs/src/changelog.md Outdated Show resolved Hide resolved
src/flow.jl Outdated Show resolved Hide resolved
@visr visr merged commit 1321ada into master Feb 3, 2022
@verseve verseve deleted the bankfull branch February 3, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verseve verseve verseve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@visr @verseve