Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when interpolating to a boundary that contains multiple polylines #372

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

Tammo-Zijlker-Deltares
Copy link
Collaborator

Fixes #370

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jun 6, 2023

Currently the warning is raised by an example script, but will then not be available to users not using the modelbuilder example script but other example code snippets. Could you instead put this warning in the used function? I believe in case of tide and other models like CMEMS, all processes pass trough interp_regularnc_to_plipoints().

@Deltares Deltares deleted a comment from veenstrajelmer Jun 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tammo-Zijlker-Deltares
Copy link
Collaborator Author

Unfortunately I could not undo the commits (otherwise the undoing of commits again shows up). I have removed all changes from workinprogress_modelbuilder

@Deltares Deltares deleted a comment from veenstrajelmer Jun 7, 2023
Copy link
Collaborator

@veenstrajelmer veenstrajelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All previous comments were processed

@veenstrajelmer veenstrajelmer merged commit 08238c4 into main Jun 7, 2023
5 of 7 checks passed
@Tammo-Zijlker-Deltares Tammo-Zijlker-Deltares deleted the Tammo-Zijlker-Deltares/issue370 branch June 16, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning when interpolating to a boundary that contains multiple polylines
2 participants