369 Make a proper selection for either CMEMS reanalysis or forecast product #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veenstrajelmer
requested changes
Jun 21, 2023
dfm_tools/download.py
Outdated
Comment on lines
90
to
112
| global product #set product as global variable, so it only has to be retreived once per download run (otherwise once per variable) | ||
| if 'product' not in globals(): | ||
| print('retrieving time range of CMEMS reanalysis product') | ||
| dataset_url = 'https://my.cmems-du.eu/thredds/dodsC/cmems_mod_glo_phy_my_0.083_P1D-m' #assuming here that physchem and bio reanalyisus/multiyear datasets have the same enddate, this seems safe | ||
| ds = open_OPeNDAP_xr(dataset_url=dataset_url, credentials=credentials) | ||
| my_times = ds.time.to_series() | ||
| global my_datemax | ||
| my_datemax = my_times.iloc[-1] | ||
|
|
||
| if pd.Timestamp(date_max) <= my_datemax: | ||
| product = 'reanalysis' | ||
| elif pd.Timestamp(date_min) > my_datemax: | ||
| product = 'analysisforecast' | ||
| else: | ||
| raise ValueError(f'Requested timerange is {date_min} to {date_max}. Currently, it is only possible to query periods before OR after the multiyear/reanalysis enddate ({my_datemax}).') | ||
| reanalysis_t0, reanalysis_tend = my_times.iloc[0], my_times.iloc[-1] | ||
| if (date_min >= reanalysis_t0) & (date_max <= reanalysis_tend): | ||
| product = 'reanalysis' | ||
|
|
||
| if 'product' not in globals(): #apparently, the reanalysis is not sufficient. Let's check forecast product. | ||
| print('retrieving time range of CMEMS forecast product') | ||
| dataset_url = 'https://nrt.cmems-du.eu/thredds/dodsC/cmems_mod_glo_phy_anfc_0.083deg_P1D-m' #assuming here that physchem and bio reanalyisus/multiyear datasets have the same enddate, this seems safe | ||
| ds = open_OPeNDAP_xr(dataset_url=dataset_url, credentials=credentials) | ||
| my_times = ds.time.to_series() | ||
| forecast_t0, forecast_tend = my_times.iloc[0], my_times.iloc[-1] | ||
| if (date_min >= forecast_t0) & (date_max <= forecast_tend): | ||
| product = 'analysisforecast' | ||
|
|
||
| if 'product' not in globals(): | ||
| raise ValueError(f'Requested timerange ({date_min} to {date_max}) is not fully within timerange of reanalysis product ({reanalysis_t0} to {reanalysis_tend}) or forecast product ({forecast_t0} to {forecast_tend}).') | ||
| else: | ||
| print(f"The CMEMS '{product}'-product will be used.") |
There was a problem hiding this comment.
I suggest a different approach. Retrieve start/stoptime for both multiyear/forecast, save as variables. Then do the check and decide the product. It will make the code shorter and easier to understand.
|
Kudos, SonarCloud Quality Gate passed!
|
veenstrajelmer
approved these changes
Jun 22, 2023
dfm_tools/download.py
Outdated
Comment on lines
93
to
94
| date_min = pd.Timestamp(date_min)-pd.Timedelta(days=1) #CMEMS has daily noon values (not midnight), so subtract one day from date_min to cover desired time extent | ||
| date_max = pd.Timestamp(date_max) |
There was a problem hiding this comment.
to be replaced by function (maybe first lets merge PR 390 and then update branch), see #390 (comment)
dfm_tools/download.py
Outdated
Comment on lines
88
to
91
| def get_time_range_from_dataset(dataset_url, credentials): | ||
| ds = open_OPeNDAP_xr(dataset_url=dataset_url, credentials=credentials) | ||
| my_times = ds.time.to_series() | ||
| global my_datemax | ||
| my_datemax = my_times.iloc[-1] | ||
|
|
||
| if pd.Timestamp(date_max) <= my_datemax: | ||
| product = 'reanalysis' | ||
| elif pd.Timestamp(date_min) > my_datemax: | ||
| product = 'analysisforecast' | ||
| else: | ||
| raise ValueError(f'Requested timerange is {date_min} to {date_max}. Currently, it is only possible to query periods before OR after the multiyear/reanalysis enddate ({my_datemax}).') | ||
| return [my_times.iloc[0], my_times.iloc[-1]] |
There was a problem hiding this comment.
- move new function out of download_CMEMS function (e.g. bottom of script), I also suggest to add
OPeNDAPin the name myinmy_timeswas for multiyear, maybe rename itds_times- square brackets can be left out:
return my_times.iloc[0], my_times.iloc[-1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369