Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wgs84/projected_coordinate_system vars with attrs to network file #422

Merged

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Jul 4, 2023

The variable wgs84 or projected_coordinate_system is created to enable dflowfm to distinguish between spherical/cartesian. For interacter, a network seems to be interpreted as cartesian, unless there is this empty wgs84 variable present with at least some of the prescribed attrs. However, in order to let the DeltaShell GUI read the coordinate system properly, probably more is needed. I have also seen a warning message from the kernel for a spherical model:
"** WARNING: Missing coordinate reference system. Now using default: wgs84 (EPSG:4326)."
For cartesian models, there might be even more information like a wkt attribute needed.

Could you provide feedback on what the GUI/kernel (minimally) expects/needs in order to properly read a network file and also where to get this information?

I see the wkt information can come from gdal, but since this is not pip installable I would like to avoid that dependency.

EDIT:
All now works (interacter and QGIS), one additional update is needed to wrap up this PR:

  • check whether kernel also knows enough with this minimal epsg writing, there is a warning about a proj string not being read properly.

@veenstrajelmer veenstrajelmer linked an issue Jul 4, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@veenstrajelmer veenstrajelmer merged commit c977c37 into main Jul 6, 2023
3 checks passed
@veenstrajelmer veenstrajelmer deleted the 421-add-wgs84projected-variable-to-network-netcdf-file branch July 6, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add wgs84/projected variable to network netcdf file
1 participant