-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added wgs84/projected_coordinate_system vars with attrs to network file #422
Merged
veenstrajelmer
merged 24 commits into
main
from
421-add-wgs84projected-variable-to-network-netcdf-file
Jul 6, 2023
Merged
added wgs84/projected_coordinate_system vars with attrs to network file #422
veenstrajelmer
merged 24 commits into
main
from
421-add-wgs84projected-variable-to-network-netcdf-file
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elbuilder and gridgeneration example scripts
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
veenstrajelmer
deleted the
421-add-wgs84projected-variable-to-network-netcdf-file
branch
July 6, 2023 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
wgs84
orprojected_coordinate_system
is created to enable dflowfm to distinguish between spherical/cartesian. For interacter, a network seems to be interpreted as cartesian, unless there is this empty wgs84 variable present with at least some of the prescribed attrs. However, in order to let the DeltaShell GUI read the coordinate system properly, probably more is needed. I have also seen a warning message from the kernel for a spherical model:"** WARNING: Missing coordinate reference system. Now using default: wgs84 (EPSG:4326)."
For cartesian models, there might be even more information like a
wkt
attribute needed.Could you provide feedback on what the GUI/kernel (minimally) expects/needs in order to properly read a network file and also where to get this information?
I see the wkt information can come from gdal, but since this is not pip installable I would like to avoid that dependency.
EDIT:
All now works (interacter and QGIS), one additional update is needed to wrap up this PR: