Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for colon in cds apikey #514

Merged
merged 4 commits into from
Sep 15, 2023
Merged

check for colon in cds apikey #514

merged 4 commits into from
Sep 15, 2023

Conversation

JulienGroenenboom
Copy link
Collaborator

No description provided.

@JulienGroenenboom JulienGroenenboom linked an issue Sep 13, 2023 that may be closed by this pull request
Add required UID to CDS API key for ERA5 download #513
Closed
@JulienGroenenboom JulienGroenenboom requested review from veenstrajelmer and removed request for veenstrajelmer September 14, 2023 09:40
@veenstrajelmer veenstrajelmer changed the title Update download.py check for colon in cds apikey Sep 15, 2023
veenstrajelmer
veenstrajelmer reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@veenstrajelmer veenstrajelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used the cds notation and avoided curly brackets which might be confusing to users not familiar with the f-string notation.

@veenstrajelmer
used the cds notation and avoided curly brackets that might be confus…
c7be976 
…ing for users not familiar with python f-string notation
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JulienGroenenboom JulienGroenenboom merged commit 52e00f6 into main Sep 15, 2023
6 checks passed
@JulienGroenenboom JulienGroenenboom deleted the 513-add-required-uid-to-cds-api-key-for-era5-download branch September 15, 2023 06:19
@veenstrajelmer veenstrajelmer mentioned this pull request Sep 15, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veenstrajelmer veenstrajelmer veenstrajelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add required UID to CDS API key for ERA5 download
2 participants
@JulienGroenenboom @veenstrajelmer