1025/caching cloud #1026
Merged
1025/caching cloud #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaapel
force-pushed
the
1025/caching_cloud
branch
from
1a50440
to
9cff0b8
Compare
savente93
reviewed
Jul 12, 2024
Co-authored-by: Sam Vente <savente93@proton.me>
… 1025/caching_cloud
savente93
reviewed
Jul 16, 2024
| if vrt_ref_el is None: | ||
| raise ValueError(f"Could not find Source File in vrt: {vrt_uri}.") | ||
| vrt_ref: str = vrt_ref_el.text.replace("\\", os.sep) # dewindowsify | ||
| vrt_relative: int = int(vrt_ref_el.get("relativeToVRT")) # 0 or 1 |
There was a problem hiding this comment.
The source format gives either 0 or 1, I like to represent it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #1025
Explanation
Wanted to fix the AWS data catalog.
Noticed that the dataset tested used a gdal virtual filesystem. This messes with the caching settings. Of course this path is different in windows and linux, so the code had to be revised.
Then that the .vrt caching did not cache at all: the
intersectsin-line functions was not correct and skipped all caching.The vrt also had to be altered to account for the cached files.
General Checklist
v1Additional Notes (optional)
I did change the data catalog for GCP CMIP6 data. But as we are still in alpha, i do not release a new version.