Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mesh_2d_from_rasterdataset for rasterdatasets with multidimension… #843

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

roeldegoede
Copy link
Contributor

…al coordinates

Issue addressed

Fixes #842

Explanation

This very simple solution solves the problems on my end, but require the latest version of xugrid.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@DirkEilander
Copy link
Contributor

Do you know what the minimal required xugrid version is @roeldegoede? Does it only work with the latest or already from earlier versions?

I'm fine with this solution and pinning a minimal version. Do you agree at @hboisgon?

TODO:

  • update changelog
  • set minimal xugrid version in pyproject.toml and pixi.toml

@roeldegoede
Copy link
Contributor Author

Yes, this support for multi-dimensional coordinates only works for versions of xugrid >= 0.9.0.

Added it to changelog and updates the minimum version.

Copy link
Contributor

@DirkEilander DirkEilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roeldegoede. LGTM!

@savente93 savente93 merged commit 9b7f394 into Deltares:main Mar 18, 2024
11 checks passed
@savente93 savente93 mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in mesh2d_from_rasterdataset for rotated rasters
3 participants