bugfix in clip_bbox for clipping on a bbox outside of rasterdataset

[roeldegoede]

Issue addressed

Fixes #859

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

• Updated tests or added new tests
• Branch is up to date with main
• Tests & pre-commit hooks pass
• Updated documentation if needed
• Updated changelog.rst if needed
• For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

[roeldegoede]

Added tests that test for clip_bbox when bbox is left, right, below or above the extent of the data.

Somehow, this does not yet fully work for rotated grids ... (see failing test) and figure below, where bbox is plotted in red (left of data extent) but the clip_bbox function still return data ..

[savente93]

Thanks for this work Roel! Good that you wrote tests, however, they are still failing. Could you take a look what is going wrong?

[DirkEilander]

Thanks @roeldegoede for the report, fix and tests. I've amended the fix slightly to work for all tests including some edge cases. I think this can be merged now.

[savente93]

Tests are green so LGTM. once you fix the merge conflict feel free to merge