Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong default value in setup_laimaps #119

Closed
DirkEilander opened this issue Nov 7, 2022 · 0 comments · Fixed by #120
Closed

wrong default value in setup_laimaps #119

DirkEilander opened this issue Nov 7, 2022 · 0 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@DirkEilander
Copy link
Contributor

The default value of the "lai_fn" argument in setup_laimaps is "model_lai" instead of "modis_lai", which it should be according to the docstring and to match the deltares_data catalog.

hydromt_wflow/hydromt_wflow/wflow.py

Line 641 in 94842f2

def setup_laimaps(self, lai_fn="model_lai"):

@DirkEilander DirkEilander added the bug Something isn't working label Nov 7, 2022
DirkEilander added a commit that referenced this issue Nov 7, 2022
@DirkEilander
fix wrong default value #119
fbe42ea
@DirkEilander DirkEilander mentioned this issue Nov 7, 2022
Merged
hboisgon added a commit that referenced this issue Nov 9, 2022
@hboisgon
Merge pull request #120 from Deltares/fix/#119
40733cd 
fix wrong default value setup_laimaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix wrong default value setup_laimaps Deltares/hydromt_wflow
1 participant
@DirkEilander