Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Raise Value Error when using non-existing PET method #201

Closed
markhegnauer opened this issue Sep 27, 2023 · 0 comments · Fixed by #227
Closed

Missing Raise Value Error when using non-existing PET method #201

markhegnauer opened this issue Sep 27, 2023 · 0 comments · Fixed by #227
Assignees
@hboisgon @dalmijn
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
2024 - high priority

Comments

@markhegnauer
Copy link
Contributor

When using a wrong PET method (non existing or typo), no ValueError is raised. leading to a very cryptic error message later on. Can be fixed on line 2036 in wflow.py

ValueError(f"Unknown pet method {pet_method}, select from {methods}")

should be

raise ValueError(f"Unknown pet method {pet_method}, select from {methods}")
@markhegnauer markhegnauer added the bug Something isn't working label Sep 27, 2023
@hboisgon hboisgon added the documentation Improvements or additions to documentation label Dec 14, 2023
@hboisgon hboisgon self-assigned this Dec 14, 2023
hboisgon added a commit that referenced this issue Dec 14, 2023
@hboisgon
fix pet_method error #201
99d90a6
@hboisgon hboisgon mentioned this issue Dec 14, 2023
Merged
4 tasks
@JoostBuitink JoostBuitink added this to the 2024 - high priority milestone Jan 24, 2024
dalmijn added a commit that referenced this issue Feb 13, 2024
@hboisgon @dalmijn
Update setup docstings (#227)
695d6b9 
* Update setup_gauges docs #198

* fix pet_method error #201

* improve setup methods docstrings #225

* update changelog

* Indentation error

* Remove optional for 'temp_pet_fn' in docstring

---------

Co-authored-by: Brendan <brencodeert@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hboisgon hboisgon

@dalmijn dalmijn

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
2024 - high priority
Development

Successfully merging a pull request may close this issue.

Update setup docstings Deltares/hydromt_wflow
4 participants
@markhegnauer @JoostBuitink @hboisgon @dalmijn