Support reading wflow models with input and/or output directories in the toml #140
Conversation
There was a problem hiding this comment.
Nice additions @JoostBuitink , thanks a lot!
I think really nice to change the default dir_output options as well: this however means that the built models will contain the change so good to check if the examples need to be updated and document the change in the changelog.
I also have a suggestion on how to insert dir_input and dir_output and suggest to apply the abs_path argument of get_config for them instead of the filename directly, might make it more robust.
|
Hi @JoostBuitink I see the tests are failing on glaciers though... not sure why... could you check it or do you prefer if I do? |
|
Hi @hboisgon! Thanks for the quick review! I have included your changes, and am currently looking in to the failing glacier test. Will let you know if I need some help with that! |
|
The failing test with the glaciers appears to be unrelated to this PR, as it also happend in another PR. I have created #143 to cover this problem |
Last year, the option to specify a
dir_inputand ordir_outputwas added to Wflow.jl. However, these options were not know to hydromt_wflow, so reading the model would skip the input and/or output files when this is specified in the Wflow .toml file. These changes fix this, and also adds thedir_outputto the default toml file to improve the user experience of Wflow.