Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local DEM #161

Merged
merged 12 commits into from Jul 27, 2023
Merged

Support local DEM #161

merged 12 commits into from Jul 27, 2023

Conversation

hboisgon
Copy link
Contributor

Support local DEM data and add notebook on examples how to create flwdir/uparea/strord based on elevation.

@hboisgon hboisgon marked this pull request as draft March 15, 2023 04:19
This was linked to issues Mar 15, 2023
Bug: deriving basin in setup_basemaps does not work without basin_index_fn #156
Closed
support local DEMs #89
Closed
@hboisgon hboisgon added this to the Release 0.3.0 milestone Mar 15, 2023
@hboisgon
Copy link
Contributor Author

hboisgon commented Mar 15, 2023 •
edited

@DirkEilander : this PR/issues were on you but I needed them earlier than what I thought for a project :)
The basin index issue was indeed a problem so this is fixed and I removed the error is crs was not 4326.
All the rest seem to work fine!

So still to do is:

  • In setup_basemaps, implement a check for if the coordinate system is projected or geographic. If projected need to update the TOML file for model.sizeinmetres = true !! Else you get a very criptic wflow error.....
  • Notebook to prepare from elevation flwdir/uparea/basins/strord
  • Docs / changelog / test? Would be nice to include test case as for eg coordinates for basin in region need to be in the DEM crs etc.

@hboisgon hboisgon linked an issue Mar 28, 2023 that may be closed by this pull request
support models in other CRS than EPSG:4326 #66
Closed
@hboisgon hboisgon marked this pull request as ready for review June 9, 2023 09:21
@hboisgon
Copy link
Contributor Author

@DirkEilander I simplified the example notebook so I think it's ready for review!

@DirkEilander DirkEilander merged commit d72640c into main Jul 27, 2023
2 checks passed
@DirkEilander DirkEilander deleted the local_dem branch July 27, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirkEilander DirkEilander DirkEilander approved these changes

Assignees

@DirkEilander DirkEilander

Labels
None yet
Projects
None yet
Milestone
Release 0.3.0
2 participants
@hboisgon @DirkEilander