Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marina pilot #209

Merged
merged 4 commits into from Dec 19, 2023
Merged

Marina pilot #209

merged 4 commits into from Dec 19, 2023

Conversation

hboisgon
Copy link
Contributor

@hboisgon hboisgon commented Oct 20, 2023

Issue addressed

I did not publish specific issues for these.

Explanation

This branch started with another goal so I will split and do 2 PRs. In this branch I focus on some bugfixing and better support of local data:

  • setup_rivers: if river depth is in the input rivers_fn then use it rather than compute from qbankfull
  • setup_reservoirs: bugfixes on required columns to better match what is in the docs
  • setup_lulcmaps: bugfix to read the mapping_table_fn
  • setup_config_output_timeseries: bugfix if reducer is provided

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed

@hboisgon
Copy link
Contributor Author

Tests are failing with new hydromt 0.9.0

Copy link
Collaborator

@dalmijn dalmijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume here that the checking whether a dataset is present, is now handled in core.

@hboisgon hboisgon merged commit e3f313c into main Dec 19, 2023
6 checks passed
@hboisgon hboisgon deleted the marina_pilot branch December 19, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants