-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #921 Update uzf #867
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0787948
Various change to UZF package for correct rendering and support of ad…
HendrikKok 695b8a2
update read_cbc_headers method to deal with uzf cbc file
HendrikKok 117e650
Update open_cbc method to deal with budget files of advanced packages…
HendrikKok cdce295
update open_cbc method to more general form so no extra input is requ…
HendrikKok 546f707
review
HendrikKok ba60742
Deal with new name prefixes
HendrikKok eb232ff
fix
HendrikKok 89c0d16
Merge branch 'master' into update_uzf
HendrikKok 242c84e
update tests
HendrikKok fc01f4c
ruff
HendrikKok 246742d
update test to deal with nodata
HendrikKok 07dbefb
move get_header_advanced_package method
HendrikKok e6f7b3c
Merge branch 'master' into update_uzf
HendrikKok 3d73429
fix circular import
HendrikKok cf0936d
linter
HendrikKok 6aab0d7
Merge branch 'master' into update_uzf
HendrikKok 15ff4fa
process review
HendrikKok c355535
fix labels in test
HendrikKok b2db8ad
linter
HendrikKok f93ea34
update changelog with master
HendrikKok 5576332
Merge branch 'master' into update_uzf
HendrikKok 62819f8
linter
HendrikKok 0fb5c5d
fix comment
HendrikKok File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,16 @@ Added | |
be selected, available in :func:`imod.prepare.DISTRIBUTION_OPTION`. | ||
- :func:`imod.prepare.celltable` supports an optional ``dtype`` argument. This | ||
can be used, for example, to create celltables of float values. | ||
|
||
- Budget arrays now contain np.nan for cells where budget variables are not defined. | ||
Based on new budget output a disquisition between active cells but zero flow and | ||
inactive cells can be made. Changes affect: | ||
:func:`imod.mf6.open_cbc` | ||
- Package type added to return budget names of CBC-output. New format is | ||
"package type"-"optional package variable"_"package name". E.g. a River package | ||
named ``primary-sys`` will get a budget name ``riv_primary-sys``. An UZF package | ||
with name ``uzf-sys1`` will get a budget name ``uzf-gwrch_uzf-sys1`` for the | ||
groundwater recharge budget from the UZF-CBC. Changes affect: | ||
:func:`imod.mf6.open_cbc` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. idem |
||
|
||
Fixed | ||
~~~~~ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick: Best to put function at start of message. Something like: