Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mining.authorize and mining.submit messages #47

Merged
merged 2 commits into from Dec 3, 2019

Conversation

CryptoManiac
Copy link
Contributor

This is necessary for pools running EthrereumStratum protocol.

https://github.com/nicehash/nhethpool/blob/master/EthereumStratum_NiceHash_v1.0.0.txt

@Demion
Copy link
Owner

Demion commented Apr 24, 2018

Doesnt it have to be Protocols[4]?
char *Protocols[4] = {"eth_submitLogin", "eth_login", "mining.authorize", "mining.submit"};

Also, as far as I know, NiceHash does not use ethereum wallet (42 character long starting with 0x) as login.

char Wallet[43] = {0};
char *wallet = strstr(buf, "0x");
memcpy(wallet, Wallet, 42);

In angelics@c16ced0 34 character long wallet starting with X is used.

But I cannot confirm it will work either cause, as long as I understand, NiceHash use bitcoin wallet as login (or any format user name is supported by protocol) and, according to wikipedia, bitcoin wallet can vary 26-35 characters (also not sure if starting with X check is valid).

https://en.bitcoin.it/wiki/Address

I will take a look in NiceHash protocol in depth later, to confirm.

@CryptoManiac
Copy link
Contributor Author

CryptoManiac commented Apr 24, 2018

@Demion

Also, as far as I know, NiceHash does not use ethereum wallet (42 character long starting with 0x) as login.

The protocol itself is not binded to nicehash anyhow, anybody can implement it and use for own pool. There are pools running this protocol and wallet address is used for authentication.

Just for example:

https://etherdig.net/#/

@angelics
Copy link

since mining.authorize and mining.submit is here,
im nt sure if its possible. can make the devfee address and length read from devfee.txt?
address length
this will make nodevfee.exe to run globally for all types of miners.
a recompile of dll is needed if address and length changed.

@Demion
Copy link
Owner

Demion commented Apr 26, 2018

Only complete solution is obviously to parse json and determine address / login length, which may create little overhead, but still planned for future releases.

@Demion Demion merged commit 13986be into Demion:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants