New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Bexley #336
Merged
Merged
Import Bexley #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains: 1. Clean/importer scripts for AddressBase 2. Models for storing addresses 3. Helpers for making addresses for areas with postcodes split over districts
Now return a dict containing the total of postcodes for an area as well as the ones that need attention
This deals with the case where a council have 'split' the polling district in to two different polling places, but they're actually the same place.
This allows us to get the centre point from a list of postcodes
I *think* using all fields will be slower, but either way this is more Djangoy
This is a massive speed up – if an importer class defines a `get_station_hash` method, then use that to remember polling stations we've imported. This prevents re-geocoding/creating the object in the DB and reduces the import time from over 5 minutes to under 10 seconds.
This fixes the issue of ambiguous addresses, as outlined in #282 by deleting duplicates after import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315, based off #326