Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Bexley #336

Merged
merged 28 commits into from Jun 20, 2016
Merged

Import Bexley #336

merged 28 commits into from Jun 20, 2016

Conversation

symroe
Copy link
Member

@symroe symroe commented Jun 19, 2016

Fixes #315, based off #326

symroe added 28 commits June 17, 2016 15:28
This contains:

1. Clean/importer scripts for AddressBase
2. Models for storing addresses
3. Helpers for making addresses for areas with postcodes split over districts
Now return a dict containing the total of postcodes for an area
as well as the ones that need attention
This deals with the case where a council have 'split' the polling district in to two different polling places, but they're actually the same place.
This allows us to get the centre point from a list of postcodes
I *think* using all fields will be slower, but either way this is more Djangoy
This is a massive speed up – if an importer class defines a `get_station_hash` method, then use that to remember polling stations we've imported. This prevents re-geocoding/creating the object in the DB and reduces the import time from over 5 minutes to under 10 seconds.
This fixes the issue of ambiguous addresses, as outlined in #282 by deleting duplicates after import
@symroe symroe added the Review label Jun 19, 2016
@symroe symroe merged commit 163347c into master Jun 20, 2016
@symroe symroe deleted the import_bexley branch June 20, 2016 07:42
@symroe symroe removed the Review label Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant