Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of og:description - addresses #99 #102

Merged
merged 2 commits into from
May 7, 2017
Merged

Fix rendering of og:description - addresses #99 #102

merged 2 commits into from
May 7, 2017

Conversation

mrwilson
Copy link
Contributor

@mrwilson mrwilson commented May 1, 2017

  • Use postelections as the list to be grouped
  • Use 'grouper' rather than pulling the date off the first election object.
  • Default text if there are no elections

- Use postelections as the list to be grouped
- Use 'grouper' rather than pulling the date off the first election object.
- Default text if there are no elections
@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.976% when pulling c9dd9f3 on mrwilson:master into dc29ea1 on DemocracyClub:master.

@chris48s
Copy link
Collaborator

chris48s commented May 7, 2017

Hi @mrwilson. Thanks for having a look at this and sorry none of us had a chance to review it before the local elections last week.

I've had a quick look at your changes on my local copy. Your changes fix the problem correctly where there are >=1 upcoming elections, but your check for the case where there are 0 elections doesn't pick up the condition correctly. I still get "On , registered voters in {postcode} will be able to vote in 0 elections".

You can fix it by changing the check to either
if not header_elections_by_date or
if postelections.count == 0.
Can you update and then we'll merge.

Thanks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.886% when pulling ad352cc on mrwilson:master into 02b01af on DemocracyClub:master.

@mrwilson
Copy link
Contributor Author

mrwilson commented May 7, 2017

Hi @chris48s - thanks for the feedback! I've added a commit to the pull request.

@chris48s
Copy link
Collaborator

chris48s commented May 7, 2017

Sorted -thanks

@chris48s chris48s merged commit bfde148 into DemocracyClub:master May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants