Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/party pages initial #1564

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Feat/party pages initial #1564

merged 4 commits into from
Apr 20, 2023

Conversation

Bekabyx
Copy link
Contributor

@Bekabyx Bekabyx commented Apr 19, 2023

The first public-facing change of the party pages overhaul 馃榿 Trello.

Ref #1200

The page at this point is pretty basic. This PR aims to:

  • Remove that horrible candidates list which used to be present on the page
  • Add text to indicate deregistered parties
  • Add text to indicate joint parties
  • Add links to the relevant page(s) on the EC's party register

To test locally:

  • Ensure you're up to date with migrations and you've run python manage.py import_parties. This changed in my previous PR so you may already be up to date, but I thought I'd mention it to stay on the safe side 馃槃
  • Run the project

Case 1: Just a standard active party

  • Load up the party page of any party who is not deregistered, joint, indie or speaker (e.g. /parties/party:804/trade-unionist-and-socialist-coalition)
  • It should look something like this:

Screenshot 2023-04-19 at 16 29 23

- Check the EC link goes to the correct party register page in English - Change the party page language to Welsh - Check the EC link goes to the correct party register page in Welsh

Case 2: Joint party

  • Load up the party page of any joint party (e.g. /parties/joint-party:53-119/labour-and-co-operative-party
  • It should look something like this:

Screenshot 2023-04-19 at 16 23 30

Case 3: Deregistered party

  • Load up the party page of any de-registered party (e.g. /parties/party:2802/abolish-the-welsh-assembly-party)
  • It should look something like this:

Screenshot 2023-04-19 at 16 28 55

Tasks

@coveralls
Copy link

Coverage Status

Coverage: 58.149% (+0.4%) from 57.787% when pulling 5f59296 on feat/party-pages-initial into e4ce247 on master.

@coveralls
Copy link

Coverage Status

Coverage: 58.149% (+0.4%) from 57.787% when pulling 33840bc on feat/party-pages-initial into e4ce247 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage: 58.149% (+0.4%) from 57.787% when pulling 33840bc on feat/party-pages-initial into e4ce247 on master.

@coveralls
Copy link

coveralls commented Apr 19, 2023

Coverage Status

Coverage: 58.149% (+0.4%) from 57.787% when pulling f5676cc on feat/party-pages-initial into 2d1299a on master.

</p>
</div>
</div>
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and below: I'm not sure this empty div is doing anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I put these in divs earlier to get the ds-stack rules to feed through but now the page format is properly sorted they've become redundant. Will remove in the next commit :)

Copy link
Member

@symroe symroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor point about divs, but this looks decent to me 馃憤

@Bekabyx Bekabyx force-pushed the feat/party-pages-initial branch 3 times, most recently from 37f12af to ff8f307 Compare April 20, 2023 12:36
@Bekabyx Bekabyx marked this pull request as ready for review April 20, 2023 12:37
- Fixed some broken logic imported from YNR
- Changed deregistered party name format
- New properties for speaker and joint party ec ids
- Indicate joint parties
- Indicate deregistered parties
- Add link(s) to EC register page
- Less cardy page design
@Bekabyx Bekabyx merged commit 331bbcb into master Apr 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants