-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/party pages initial #1564
Feat/party pages initial #1564
Conversation
1 similar comment
</p> | ||
</div> | ||
</div> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and below: I'm not sure this empty div is doing anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I put these in divs earlier to get the ds-stack
rules to feed through but now the page format is properly sorted they've become redundant. Will remove in the next commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor point about divs, but this looks decent to me 馃憤
37f12af
to
ff8f307
Compare
- Fixed some broken logic imported from YNR - Changed deregistered party name format - New properties for speaker and joint party ec ids
- Indicate joint parties - Indicate deregistered parties - Add link(s) to EC register page - Less cardy page design
ff8f307
to
f5676cc
Compare
The first public-facing change of the party pages overhaul 馃榿 Trello.
Ref #1200
The page at this point is pretty basic. This PR aims to:
To test locally:
python manage.py import_parties
. This changed in my previous PR so you may already be up to date, but I thought I'd mention it to stay on the safe side 馃槃Case 1: Just a standard active party
/parties/party:804/trade-unionist-and-socialist-coalition
)- Check the EC link goes to the correct party register page in English - Change the party page language to Welsh - Check the EC link goes to the correct party register page in Welsh
Case 2: Joint party
/parties/joint-party:53-119/labour-and-co-operative-party
Case 3: Deregistered party
/parties/party:2802/abolish-the-welsh-assembly-party
)Tasks