Feat/party pages descriptions #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bekabyx
force-pushed
the
feat/party-pages-descriptions
branch
3 times, most recently
from
8c62ad8
to
18ab1eb
Compare
VirginiaDooley
approved these changes
Apr 20, 2023
symroe
reviewed
Apr 24, 2023
| @@ -57,6 +57,13 @@ <h2>{{ object.format_name }}</h2> | |||
| {% endif %} | |||
| </div> | |||
| {% endif %} | |||
|
|
|||
| {% if object.register %} | |||
| {% blocktrans with register=object.format_register %} | |||
There was a problem hiding this comment.
if you add trimmed to this block then the the translation file isn't going to contain the newliens and it will make things a little cleaner. Not a huge deal, but it does reduce the noise in diffs when we make changes in future.
There was a problem hiding this comment.
I've added trimmed now and fixed up :)
symroe
approved these changes
Apr 24, 2023
Bekabyx
force-pushed
the
feat/party-pages-descriptions
branch
from
eacc8cf
to
969ce5b
Compare
This is wrapped inside a logic block so the section will not be shown if there are no descriptions in our DB. Also added ordering to the PartyDescription objects.
- Details whether party registered in GB or NI
Bekabyx
force-pushed
the
feat/party-pages-descriptions
branch
from
969ce5b
to
6dc1d10
Compare
symroe
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next phase of the Party Pages overhaul - now featuring more useful data for voters! Trello.
Ref #1200
This update adds:
Screenshots
To test locally:
Part 1
import_partiesparty:52)Part 2
party:52works here too)Part 3
party:51- very convenient)Tasks