Frontend snags #693
Merged
Frontend snags #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% include "elections/includes/_cancelled_election.html" with object=postelection only %} | ||
| {% else %} | ||
| <h1> | ||
| <span aria-hidden="true">🗳️</span> |
There was a problem hiding this comment.
How does icon this work?
There was a problem hiding this comment.
It's just the unicode emoji "Ballot Box with Ballot" - I like using emoji as a free way to add icons - no icon font or images required!
The aria-hidden="true" is to stop screen readers reading the emoji out - there's no value in the icon being there as it's just visual decoration, so we don't want each heading to be read as "Ballot box with ballot Stroud local election ballot box with ballot"
VirginiaDooley
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to write up some issues about these, but in doing so realised it would be quicker to do the work!
Ballot page cards no longer clash
CVs are gone
We don't have new ones, or a quick way to remove them, so let's ignore them at the moment
Fixes #691
Companies are gone
As per CVs, more problem than they're worth
Don't link to the leaflets site, it's down
We can add back in if we get the site up again, so just commented out
Link and sort a person's upcoming ballots