Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo upload efficiency improvements #150

Closed
jf1 opened this issue Apr 28, 2017 · 5 comments
Closed

Photo upload efficiency improvements #150

jf1 opened this issue Apr 28, 2017 · 5 comments
Assignees

Comments

@jf1
Copy link

jf1 commented Apr 28, 2017

Part 1

Current flow:

  1. Go to candidate page
  2. Click: Edit candidate
  3. Wait for superfluous edit candidate page to load
  4. Click: There’s a separate page for uploading a photo

Instead, at 2, under the Edit candidate button, a link for Or upload a photo (of [candidate name]) could be placed here to replace steps 2 and 3 with a single click achieving what step 4 currently does.

Part 2

On the photo upload page the uploader isn't shown the photo policy (see #144).

Part 3

It'd also be useful to tell uploaders that the final result will be a square image, so they should be discouraged from cropping it manually or ideally they would be given the same cropping text and function that's on the photo moderation page.

Part 4

As mentioned in mysociety/yournextrepresentative#981 the best option for uploaders would be if, as well as the option to upload a file, they had another option to:
Enter two URLs (image url and source url)
Then crop the photo themselves before clicking Submit.

Photos can be automatically imported from facebook using:
https://developers.facebook.com/docs/graph-api/reference/user/picture/
https://developers.facebook.com/docs/graph-api/reference/page/picture/


Updated by @octopusinvitro to split the issue in its different parts

@mhl
Copy link
Collaborator

mhl commented May 8, 2017

There are a lot of different suggestions here, but I've suggested that @octopusinvitro does this bit today first of all:

Instead, at 2, under the Edit candidate button, a link for Or upload a photo (of [candidate name]) could be placed here to replace steps 2 and 3 with a single click achieving what step 4 currently does.

And after that we'll look at adding the policy text, and after that upload from a URL.

@JoeMitchell
Copy link
Contributor

Remember that Joe R in his facebook video was trying to click on the blank face image below!

image

@JoeMitchell
Copy link
Contributor

(Sorry if this is too late!)

@mhl
Copy link
Collaborator

mhl commented May 9, 2017

@JoeMitchell yep - thanks, @zarino and @octopusinvitro have watched the video and noted that.

@octopusinvitro
Copy link
Collaborator

octopusinvitro commented May 9, 2017

I have edited the issue to split all the different parts.

Part 1 done here: #176

Part 2 done here: #189 ✔️ Merged

I'm gonna start now working on Part 4 if nobody is working on it

(apparently we won't implement part 3, or at least not yet)

octopusinvitro added a commit that referenced this issue May 10, 2017
Thanks to bug reporter jf1 for reporting this in:

    #150

To upload a photo of a candidate the current flow is:

1. Go to candidate page
2. Click "Edit candidate"
3. Wait for edit-person page to load
4. Click "There’s a separate page for uploading a photo"

Instead, at 2, under the "Edit candidate" button, a link for "Upload
candidate photo" was placed to replace steps 2 and 3 with a single click
achieving what step 4 currently does.
octopusinvitro added a commit that referenced this issue May 11, 2017
Thanks to bug reporter jf1 for reporting this in:

    #150

To upload a photo of a candidate the current flow is:

1. Go to candidate page
2. Click "Edit candidate"
3. Wait for edit-person page to load
4. Click "There’s a separate page for uploading a photo"

Instead, at 2, under the "Edit candidate" button, a link for "Upload
candidate photo" was placed to replace steps 2 and 3 with a single click
achieving what step 4 currently does.
@mhl mhl closed this as completed May 21, 2017
@mhl mhl removed the 3 - Now label May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants