Fix new person form validation #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was caused by the form using the `to_python` value of the field, in other words the model object. The string version of this was something like `<Ballot ballot_paper_id='local.leeds.morley-south.2021-05-06' winner_count=1>`. This in turn was being submitted to the field, and a ValidationError was being raised, as that string isn't a valid ballot_paper_id. The fix is to use prepare_value. This method is undocumented, but is used by Djanog form fields themselves.
VirginiaDooley
approved these changes
Apr 7, 2021
michaeljcollinsuk
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.