Hackathon: GitxChange Polish, Test And Deploy A Quadratic Voting DAO #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the hackathon performed the following steps:
1. fixed compile errors.
2. fixed no opcode errors (after deploy).
3. efficiency adjustments in moloch.sol contract.
4. logic adjustments in moloch.sol contract, main adjustments:
- submitVote() -> removed the option to add new candidates based on new votes. Because of potential bugs in the current implementation and the fact that adding a new candidate during the vote gives a disadventage for the new candidate (less time).
- submitVote() -> changed calculation of total quadratic votes. Previous was square root of total votes. New is add square root of votes per voter (minus old square root).
- processProposal() -> check for equal amount of votes, returns no outcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the hackathon performed the following steps:
The contract is deployed to the ropsten test network at address: 0x3f3B0f3EF096d893DCba8F9841F12120737C77E9
Constructor variables:
address for summoner: 0xEEFC1b0EC2C8609f93580f5CdeDF29997C351f39,
approved token: 0xb603cea165119701b58d56d10d2060fbfb3efad8 (WETH Ropsten),
period duration: 17280,
voting period: 35,
grace period: 35,
abort window: 5,
proposal deposit: 10,
dilution bond: 3,
processing reward: 1,
quadratic mode: 1(bool) (true)
Note that these adjustments DO NOT guarentee that there are no bugs. I would advise further testing, a detailed check of the code and an audit before deployment to mainnet.