We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We recently added support for rendering meta headers on the backend, and should do that for all pages
Checklist
Add page handlers in context_preload.py
Remove Header component on frontend
Remove React Helmet dependency
Trello Card
The text was updated successfully, but these errors were encountered:
Here's some code examples of how to do this, as several pages already have backend meta tag rendering:
For the About page, the information is defined here: https://github.com/DemocracyLab/CivicTechExchange/blob/master/civictechprojects/helpers/context_preload.py#L87-L91
and then we use FrontEndSection to make sure that information goes where it belongs: https://github.com/DemocracyLab/CivicTechExchange/blob/master/civictechprojects/helpers/context_preload.py#L183
And the about page has the correct meta information:
The component we want to remove, Headers.jsx (which uses React Helmet) is here: https://github.com/DemocracyLab/CivicTechExchange/blob/master/common/components/common/Headers.jsx and only used in two places. Unfortunately, they're the two most complicated to replace - they need to respond to whatever project or group data is loaded.
Sorry, something went wrong.
Merge pull request #1018 from DemocracyLab/495-render-all-page-header…
53978c5
…s-on-backend-remove-react-helmet-component solve #495 render all page headers on backend remove react helmet component
Fixed by #1018
QuanGiap
Successfully merging a pull request may close this issue.
We recently added support for rendering meta headers on the backend, and should do that for all pages
Checklist
Add page handlers in context_preload.py
Remove Header component on frontend
Remove React Helmet dependency
Trello Card
The text was updated successfully, but these errors were encountered: