Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approving volunteer from email fails if not logged in #718

Closed
marlonkeating opened this issue Aug 6, 2021 · 0 comments · Fixed by #1013
Closed

Approving volunteer from email fails if not logged in #718

marlonkeating opened this issue Aug 6, 2021 · 0 comments · Fixed by #1013
Assignees
@QuanGiap
Labels
Full Stack Both front- and back-end work required

Comments

@marlonkeating
Copy link
Contributor

marlonkeating commented Aug 6, 2021 •
edited

If a project owner clicks on 'Approve Volunteer' in the volunteer application email, and they are not logged on, they will be redirected to the log in page. Upon successful login, they are redirected to an error page rather than approving successfully.

Test Cases

  • When a project owner clicks 'Approve Volunteer' for an application to their project, and they are not logged in, they are prompted to log in, and once successfully logged in they are redirected to the project profile page with the message that the approval was successful
  • Logging on to democracylab returns user to the page they were last on
@marlonkeating marlonkeating added the Full Stack Both front- and back-end work required label Aug 6, 2021
@rohitk18 rohitk18 mentioned this issue Sep 1, 2021
Closed
@marlonkeating marlonkeating linked a pull request Sep 1, 2021 that will close this issue
Added urls for approving volunteers by owners when not logged in #743
Closed
@marlonkeating marlonkeating assigned QuanGiap and unassigned rohitk18 Aug 2, 2023
@marlonkeating marlonkeating linked a pull request Aug 7, 2023 that will close this issue
Approve volunteer #718 #1013
Merged
marlonkeating added a commit that referenced this issue Oct 21, 2023
@marlonkeating
Merge pull request #1013 from DemocracyLab/approve_volunteer_#718
314aa3f 
Approve volunteer #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuanGiap QuanGiap

Labels
Full Stack Both front- and back-end work required
Projects
None yet
Milestone
No milestone
3 participants
@marlonkeating @rohitk18 @QuanGiap