Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test precheck to PR's #1073

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Add unit test precheck to PR's #1073

wants to merge 27 commits into from

Conversation

hyihua
Copy link
Collaborator

@hyihua hyihua commented Nov 19, 2023

This pull request is to address the issue #1055, which includes unit tests for python files and for JavaScript files.

@hyihua hyihua linked an issue Nov 19, 2023 that may be closed by this pull request
Add unit test precheck to PR's #1055
Open
qchiujunhao and others added 24 commits November 18, 2023 22:38
@qchiujunhao
changed python3.8 -> 3
750f12f 
so that I can pass the pre-commit
@qchiujunhao
removed the action for push
4e71487
@hyihua
rectify the name of the docker image
1329aca
@hyihua
Correct the python version
fc528e5
@hyihua
set up the step to run docker container
f682233
@hyihua
change the docker image name.
07212e9
@hyihua
correct typo
9be8c22
@qchiujunhao
javascript unittest
c783e5b
@hyihua
update commands for running tests using docker-compose
e57637e
@hyihua
run commands without using docker
676043d
@hyihua
generate .env file for using docker-compose
9a76cd1
@hyihua
print docker compose log for debugging
85822b9
@hyihua
add a service test in docker-compose.yml
37c3769
@hyihua
update the service test in docker-compose.yml
febe27a
@hyihua
remove the steps for js test for debugging
ac15ae5
@hyihua
Create unittest_without_docker.yml
b0af506
@hyihua
remove unittest_without_docker.yml
40e8b69
@hyihua
correct typo
5213e8c
@hyihua
update unittest.yml by executing tests inside the docker container
0cdb69e
@qchiujunhao
deleted the test service
487bf5d 
After discussion with Yihua, we do not need this service for unittest, we use web service
@hyihua
add "-T" flag to avoid "not TTY" error.
c00db0c
@qchiujunhao
commented python unittest for testing other actions
14a9616
@qchiujunhao
Update unittest.yml
ec06d1b
@qchiujunhao
uncommented python unittest
9d31673
@qchiujunhao qchiujunhao marked this pull request as ready for review December 10, 2023 22:16
@qchiujunhao
Copy link
Collaborator

@marlonkeating this PR is ready for review. The python unittest failed but not because of this PR. The only passed check in this PR could be the testing reference(SHA: ec06d1b) for reviewing. So we created a new issue #1078 for the failed python unittest. They can be resolved separately.

@qchiujunhao
Copy link
Collaborator

Adding more description here for better review -- The only passed check ec06d1b was because we removed python unit test to only run javascript tests. And it proves the changes on github actions are good to merge. But because #1078, the python unit test failed, which has nothing to do with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlonkeating marlonkeating Awaiting requested review from marlonkeating

At least 1 approving review is required to merge this pull request.

Assignees

@hyihua hyihua

@qchiujunhao qchiujunhao

Labels
DevOps ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test precheck to PR's
2 participants
@hyihua @qchiujunhao