Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for changing Event zoom room links + Event Fixes #943

Merged
merged 6 commits into from
May 9, 2023
Merged

Support for changing Event zoom room links + Event Fixes #943

merged 6 commits into from
May 9, 2023

Conversation

marlonkeating
Copy link
Contributor

@marlonkeating marlonkeating commented Jan 26, 2023 •
edited
Loading

Assorted fixes to support Events

Caching

  • Event Rooms can be altered on the admin page, and they now refresh the event cache so changes are immediately viewable

Fixes

Home Page

  • Upcoming event is now shown until the end of the event, not the beginning of the event

Event Page

  • RSVP Modal: Sign up/Cancel buttons now shown alongside Join Video button
  • RSVP Modal: Join Video button no longer shown when event has been deactivated

@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 26, 2023 07:01 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 26, 2023 07:42 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 27, 2023 18:25 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 27, 2023 18:36 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 28, 2023 00:50 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 28, 2023 01:13 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 28, 2023 06:10 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 28, 2023 06:18 Inactive
@marlonkeating marlonkeating changed the title Support for changing Event zoom room links Support for changing Event zoom room links + Event Fixes Jan 28, 2023
@marlonkeating marlonkeating temporarily deployed to democracy-lab February 7, 2023 06:43 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-dev May 3, 2023 04:20 Inactive
PeterBreen
PeterBreen approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@PeterBreen PeterBreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got that last bit of feedback handled (thanks, Marlon) and the rest still looks just fine as it always did.

@marlonkeating marlonkeating merged commit 506de6a into master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterBreen PeterBreen PeterBreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marlonkeating @PeterBreen