Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Update diff view - Add/Remove over the same text. #29

Closed
vmariano opened this issue Nov 6, 2014 · 6 comments
Closed

Update diff view - Add/Remove over the same text. #29

vmariano opened this issue Nov 6, 2014 · 6 comments
Assignees
@vmariano
Milestone
0.0.3

Comments

@vmariano
Copy link
Contributor

vmariano commented Nov 6, 2014

The idea, is don't show the side view in case of the only changes are adds/removes.

2014-11-06 12 13 14
@vmariano vmariano added this to the 0.0.3 milestone Nov 6, 2014
@vmariano
Copy link
Contributor Author

This will be change by some kind of approach, but side by side.
mix 1

@gvilarino
Copy link
Member

👍

@gvilarino
Copy link
Member

Check this out @rodolfopettinari

(as well as the rest of the issues)

@gvilarino gvilarino mentioned this issue Nov 12, 2014
Closed
@mairwilliams
Copy link

I like it side by side. I had in mind some kind of mouse-over pop-up but that would be gross for large changes, right?
It's still visually confusing (overwhelming), tho. Maybe the same but making the parts with no changes look more invisible (as the text I see above)... like this.
bill tracker

@gvilarino
Copy link
Member

Mouse over isn't a reliable approach since you don't have that in touch interfaces

—
Sent from Mailbox

On Wed, Nov 12, 2014 at 8:47 PM, mairwilliams notifications@github.com
wrote:

I like it side by side. I had in mind some kind of mouse-over pop-up but that would be gross for large changes, right?
It's still visually confusing (overwhelming), tho. Maybe the same but making the parts with no changes look more invisible (as the text I see above)... like this.

bill tracker

Reply to this email directly or view it on GitHub:
#29 (comment)

@vmariano vmariano mentioned this issue Nov 13, 2014
Open
vmariano added a commit that referenced this issue Nov 18, 2014
@vmariano
Update diff view - Add/Remove over the same text. #29
511e3fe 
- Change color styles.
- Add the status 'add' to transform as text.
- Refactor text introducing the concept of "section"
- Change jade template to ripple template.
- Add slide to left on toggle side view.
@vmariano
Copy link
Contributor Author

I would like keep the ideas discussed here on #11

@vmariano vmariano self-assigned this Nov 18, 2014
@vmariano vmariano mentioned this issue Nov 18, 2014
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vmariano vmariano

Labels
None yet
Projects
None yet
Milestone
0.0.3
Development

No branches or pull requests
3 participants
@vmariano @gvilarino @mairwilliams